Explain that no struct can be created as transaction input other than some exceptions #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some exceptions.
nikos-terzo
commented
Aug 13, 2024
damirka
reviewed
Aug 25, 2024
damirka
reviewed
Aug 25, 2024
| - std::string::String | ||
| - vector of pure types | ||
| - Option of pure types | ||
| - ID, a special type that refers to a unique identifier of an object |
There was a problem hiding this comment.
Ditto, not a special type, defined in sui::object::ID. Link one of the object chapters.
There was a problem hiding this comment.
object/object-model seems more appropriate as it refers to the UID.
There was a problem hiding this comment.
After all, I linked storage/uid-and-id. I also referred to object/object-model as "See also".
a49b910
damirka
reviewed
Aug 25, 2024
damirka
reviewed
Aug 26, 2024
damirka
reviewed
Aug 26, 2024
| - [`std::ascii::String`](../move-basics/string.html#ascii-strings), ASCII strings. | ||
| - [`vector<T>`](../move-basics/vector.html), where `T` is a pure type. | ||
| - [`std::option::Option<T>`](../move-basics/option.html), where `T` is a pure type. | ||
| - [`std::object::ID`](../storage/uid-and-id.html), takes part in the Unique IDentifier (UID) of an object. See also [What is an Object](../object/object-model.html). |
There was a problem hiding this comment.
I wouldn't mention anything UID here. ID is just a type which typically points to an object, though it's not a requirement.
damirka
approved these changes
Aug 27, 2024
|
@nikos-terzo LGTM! Thank you for doing this and for carrying out the edit process! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happened to waste some time in my move learning process trying to see whether structs with
copyability could be created from the client side and passed into MoveVM. A colleague did the same thing too. Maybe we need to make this explicit.I am not sure whether the format and places I used are the best.