Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[book] Minor edits #64

Merged
merged 18 commits into from
May 17, 2024
Merged

[book] Minor edits #64

merged 18 commits into from
May 17, 2024

Conversation

damirka
Copy link
Collaborator

@damirka damirka commented May 13, 2024

  • renames for chapters
  • use code samples in primitive types
  • more cross-linking
  • adds sui move test CI (a huge win)

@damirka damirka requested a review from ronny-mysten May 13, 2024 11:19
@damirka damirka self-assigned this May 13, 2024
@damirka damirka requested a review from tnowacki May 13, 2024 13:08
Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

constants are defined as `const` declarations and are usually prefixed with `E` followed by a camel
case name. Error constants are no different from other constants and don't have special handling. So
their addition is purely a practice for better code readability.
To make error codes more descriptive, it is a good practice to define
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzakian we will need to rewrite this section again soon

@@ -1,4 +1,4 @@
# Assert and Abort
# Aborting Execution
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@damirka damirka merged commit 90b7388 into main May 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants