Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge auto scrolling container with scrolling container #575

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

MyreMylar
Copy link
Owner

Since there wasn't that much code left in the auto scrolling container anyway it seems easier just to merge this functionality into the base container and turn it on by default with a parameter to control turning it off as is needed.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.25%. Comparing base (371b0f1) to head (67384e1).

Files Patch % Lines
pygame_gui/elements/ui_scrolling_container.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   96.26%   96.25%   -0.01%     
==========================================
  Files          89       89              
  Lines       13156    13153       -3     
==========================================
- Hits        12665    12661       -4     
- Misses        491      492       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MyreMylar
Copy link
Owner Author

will do this simple functionality merge for now - for the UIForm PR and further testing - but will likely swap it over in there and then remove it entirely.

@MyreMylar MyreMylar merged commit dc94a88 into main Apr 12, 2024
22 checks passed
@MyreMylar MyreMylar deleted the merge-auto-scroll-into-scroll branch April 13, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant