Merge pull request #655 from MyreMylar/fix-text-hyper-link-mousescroll

Fixing hyperlinks after mousewheel
MyreMylar · Nov 10, 2024 · 4caccad · 4caccad
2 parents 8235cd8 + 19059d7
commit 4caccad
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/pygame_gui/elements/ui_form.py b/pygame_gui/elements/ui_form.py
@@ -440,7 +440,8 @@ def __init__(self,
                          parent_element=parent_element,
                          object_id=object_id,
                          anchors=anchors,
-                         visible=visible)
+                         visible=visible,
+                         should_grow_automatically=True)
 
         self._create_valid_ids(container=container,
                                parent_element=parent_element,

diff --git a/pygame_gui/elements/ui_scrolling_container.py b/pygame_gui/elements/ui_scrolling_container.py
@@ -49,7 +49,7 @@ def __init__(self,
                  element_id: Union[List[str], None] = None,
                  anchors: Optional[Dict[str, Union[str, UIElement]]] = None,
                  visible: int = 1,
-                 should_grow_automatically: bool = True,
+                 should_grow_automatically: bool = False,
                  allow_scroll_x: bool = True,
                  allow_scroll_y: bool = True,
                  ):

diff --git a/pygame_gui/elements/ui_text_box.py b/pygame_gui/elements/ui_text_box.py
@@ -202,6 +202,8 @@ def __init__(self,
         self.copy_text_enabled = True
         self.paste_text_enabled = False
 
+        self.has_edit_cursor = False
+
         self.rebuild_from_changed_theme_data()
 
     @property
@@ -461,7 +463,7 @@ def update(self, time_delta: float):
                 self.edit_position = self.select_range[1]
                 self.cursor_has_moved_recently = True
 
-        if self.cursor_has_moved_recently:
+        if self.cursor_has_moved_recently and self.has_edit_cursor:
             self.cursor_has_moved_recently = False
 
             self.text_box_layout.set_cursor_position(self.edit_position)

diff --git a/pygame_gui/elements/ui_text_entry_box.py b/pygame_gui/elements/ui_text_entry_box.py
@@ -76,6 +76,7 @@ def __init__(self,
         self.text_box_rows = 0
 
         self.cursor_on = False
+        self.has_edit_cursor = True
 
         self.should_redraw_from_text_block = False
 

diff --git a/tests/test_elements/test_ui_scrolling_container.py b/tests/test_elements/test_ui_scrolling_container.py
@@ -384,7 +384,8 @@ def test_show_hide_rendering(self, _init_pygame, default_ui_manager, _display_su
 
         container = UIScrollingContainer(relative_rect=pygame.Rect(100, 100, 200, 100),
                                          manager=manager,
-                                         visible=0)
+                                         visible=0,
+                                         should_grow_automatically=True)
         button_1 = UIButton(relative_rect=pygame.Rect(300, 100, 150, 30),
                             text="Test Button",
                             tool_tip_text="This is a test of the button's tool tip functionality.",