Integration of Solhint for Enhanced Solidity Code Quality #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@susumutomita |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses Issue #19 by integrating Solhint, a linter for Solidity, into our project. The inclusion of a linter is crucial as our project continues to involve more smart contract development on Ethereum. Here are the key changes made in this PR:
Changes
package.json..solhint.jsonconfiguration file.It's worth noting that upon running Solhint, numerous linting errors were identified across our Solidity files. Addressing these errors is important for improving the overall code quality of our project. However, to keep this PR focused and manageable, I plan to address the linting errors in a separate follow-up PR. This approach will also allow us to discuss and potentially adjust our Solhint configuration or coding standards as needed before correcting all identified issues.