Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about missing glyphs in all code paths #16

Open
Munter opened this issue Jan 1, 2018 · 0 comments
Open

Warn about missing glyphs in all code paths #16

Munter opened this issue Jan 1, 2018 · 0 comments

Comments

@Munter
Copy link
Owner

Munter commented Jan 1, 2018

The current implementation warn about missing glyphs, but only for local subsetting, which might not be the most likely entry first-use case.

  • Move missing glyph check to run on the output of the subsetting pipeline
  • Use https://www.npmjs.com/package/font-cmap to gain independence of fonttools
    • Remove double call to pyftsubset with error handlign and recovery
  • Change the per-page text aggregation to not be overridden in the case where we're configured to use a site-wide subset. Keep test per page, also create site-wide subset in a different property. Switch between them based on config, or create a new property for the current set in use per page. This should enable the ability to bak track a missing glyph to a specific page
  • Improve error message of missing glyphs per page. Possible narrowing it down to exact line and char offset on the page (if the glyph is from html)

Maybe also look into the possibility of wrapping a <span> around missing glyphs that appear in html, in order to style them with the fallback system font. There will be obvious problems, liek styling from the outside hitting the span in an unintentional way, but it might be worth spending some time to map them out to lean if we can solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant