Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read last_location when teleport type is exact #464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicegamer7
Copy link
Member

This PR implements the idea I had in #450. I tested it quickly and it seemed to work.

I haven't done any extensive tests, but our unit tests didn't fail... here be dragons, proceed with caution.

Test Build:
Multiverse-Inventories-4.2.3-SNAPSHOT.jar.zip

@benwoo1110
Copy link
Member

The code generally looks ok, the only thing is this solution seems a bit hacky tho

@benwoo1110
Copy link
Member

Perhaps just adding an option to specify a list of disabled shares for each world group. That means the share will not be part of the read/write profile at all. Possibly useful if that world another plugin wants to handle health etc?

@nicegamer7
Copy link
Member Author

That might be a good idea.

@nicegamer7
Copy link
Member Author

Although, this is a little different because it still saves your last location, just won't use it sometimes.

@nicegamer7
Copy link
Member Author

I thought of a better way of doing this. I'll try it in the coming days and see if it works.

@SparksXV
Copy link

I thought of a better way of doing this. I'll try it in the coming days and see if it works.

Does this work with nether portals? I have been having issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants