Fixed incorrect mouse cursor scaling, which breaks hover/tooltips/inventory #447
Conversation
…entory The mouse cursor coordinate conversion was using “getScreenWidth()” rather than “getWidth()” (i.e. using the screen size, rather than the window size), which was resulting in an incorrect scaling factor. This fixes it, in all the places it’s used. This should fix: MrCrayfish#440 - Inventory Items are far off screen to the right when selected MrCrayfish#425 - Inventory Movement Issues MrCrayfish#336 - Items and cursor turn invisible when trying to re-order items in inventory MrCrayfish#214 - MacOS Distortion [Unplayable] on ALL Mod Versions MrCrayfish#37 - Bug: Mouse icon moves to other Minecraft screen, or vanishes when in inventory This issue is a show-stopper on macOS, and possibly on Windows with a Hi-DPI display, so I believe it’s quite high priority.
|
In case it's a while before this is merged (or isn't merged at all), here's a build with the fix: https://d.atastypixel.com/1694149137/controllable-fabric-1.20.1-0.20.3-release.jar |
|
Hello, This issue is still persisting with me. |
Oh that’s surprising! You’re definitely using the build from the links above? Assuming so, some follow up questions: What specifically are you still seeing? Are we talking about a messed-up cursor position in the inventory screen? Are you on Forge or Fabric? |
|
Hello there, Um about the issue, I've started playing on the next day now and the issue seems to e resolved. Im sorry if I wasted anyone's time |
|
Yep, I just tried it here and it's working perfectly on Forge. @MrCrayfish, I think we're good to go |
|
I can confirm that it works well on my side with this build :) |
The mouse cursor coordinate conversion was using “getScreenWidth()” rather than “getWidth()” (i.e. using the screen size, rather than the window size), which was resulting in an incorrect scaling factor. This fixes it, in all the places it’s used.
This should fix:
#440 - Inventory Items are far off screen to the right when selected
#425 - Inventory Movement Issues
#336 - Items and cursor turn invisible when trying to re-order items in inventory
#214 - MacOS Distortion [Unplayable] on ALL Mod Versions
#37 - Bug: Mouse icon moves to other Minecraft screen, or vanishes when in inventory
This issue is a show-stopper on macOS, and possibly on Windows with a Hi-DPI display, so I believe it’s quite high priority.