COM- 3305 Added string method to check special char #310
Conversation
| @@ -206,6 +206,9 @@ define([ | |||
| filter: function(collection) { | |||
| var filterStr = ""; | |||
| var qName = $("#searchName").val(); | |||
| if (typeof String.prototype.mzCheckSpacialChar === 'function') { | |||
There was a problem hiding this comment.
since mzCheckSpacialChar is part of SDK then it will always be available. so no need to check this is a function (mzCheckSpacialChar ) is available or not but not 100% sure about it.
There was a problem hiding this comment.
Yes, I added this for safer side if function is not loaded by sdk current search functionality should work, but in other side if SDK will not load mozu application will not work so I am fine to remove this if condition.
OnkarDPatil
force-pushed
the
feature/COM-2911
branch
from
66681fe
to
14e9985
Compare
There was a problem hiding this comment.
I don't think this is the best way to fix such a common use case. If we are adding a generic filter escape method we should hook it into a generic place and fix all filter request strings. Not just this one place.
See my comments on the Storefront PR. That has more details.
OnkarDPatil
force-pushed
the
feature/COM-2911
branch
from
a2aee56
to
50e5859
Compare
ghost
force-pushed
the
feature/B2B-phase-2
branch
from
b6dd923
to
d880655
Compare
ghost
closed this
ghost
mentioned this pull request
|
This PR needs to be rebased and integrate the changes from PR #346. I still think the fix there needs some more work, though. Please review my comments again. |
ghost
reopened this
SharmaBhushan
force-pushed
the
feature/COM-3305
branch
from
1d3226d
to
0c5fbf4
Compare
kibo-DeepakTajane
force-pushed
the
feature/COM-3305
branch
2 times, most recently
from
cf34680
to
6069f65
Compare
kibo-DeepakTajane
force-pushed
the
feature/COM-3305
branch
from
6069f65
to
f647718
Compare
No description provided.