Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

fix(glean): change page_url & referrer_url to be url type #94

Merged
merged 1 commit into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions telemetry/generated/web.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

// AUTOGENERATED BY glean_parser v8.1.1. DO NOT EDIT. DO NOT COMMIT.

import UrlMetricType from "@mozilla/glean/private/metrics/url";
import EventMetricType from "@mozilla/glean/private/metrics/event";
import StringMetricType from "@mozilla/glean/private/metrics/string";

/**
* Event triggered when a user clicks a link on a web page.
Expand Down Expand Up @@ -39,7 +39,7 @@ export const linkClick = new EventMetricType<{
*
* Generated from `web.page_url`.
*/
export const pageUrl = new StringMetricType({
export const pageUrl = new UrlMetricType({
category: "web",
name: "page_url",
sendInPings: ["events"],
Expand Down Expand Up @@ -77,7 +77,7 @@ export const pageView = new EventMetricType({
*
* Generated from `web.referrer_url`.
*/
export const referrerUrl = new StringMetricType({
export const referrerUrl = new UrlMetricType({
category: "web",
name: "referrer_url",
sendInPings: ["events"],
Expand Down
4 changes: 2 additions & 2 deletions telemetry/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ ui:

web:
page_url:
type: string
type: url
description: >
The full URL of the page that was visited,
along with URL query parameters.
Expand All @@ -264,7 +264,7 @@ web:
- events

referrer_url:
type: string
type: url
description: >
The full URL of the previous web page from which a link was followed
in order to trigger the page view.
Expand Down
Loading