Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

fix(post): post creation interactions [MOSOWEB-46] #76

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

jpezninjo
Copy link

@jpezninjo jpezninjo commented Nov 2, 2023

MOSOWEB-46 https://mozilla-hub.atlassian.net/browse/MOSOWEB-46

Goal

All post creations, replies and edits should have an analytics action associated.

Send the following Engagement Event:

engagement event
ui_identifier is post.create (or something like that)
Includes a mastodon_status_id that we can cross-reference against prod data
engagement_type is post

I'd love feedback/perspectives on:

Implementation Decisions

  • The oddball in the list of new events, home.post.create, is a decision from Kirill

New analytics events

  • home.post.create
  • post.create
  • post.edit
  • post.reply

@jpezninjo jpezninjo requested a review from a team as a code owner November 2, 2023 16:08
@jpezninjo jpezninjo force-pushed the fix/post-creation-interactions branch from 4c07812 to f7316bd Compare November 2, 2023 16:18
@jpezninjo jpezninjo changed the base branch from fix/posts-buttons-engagement-events to main November 2, 2023 16:20
@jpezninjo jpezninjo changed the title [draft] fix(post): creation interactions [MOSOWEB-46] fix(post): creation interactions [MOSOWEB-46] Nov 2, 2023
@jpezninjo jpezninjo changed the title fix(post): creation interactions [MOSOWEB-46] fix(post): post creation interactions [MOSOWEB-46] Nov 2, 2023
? 'post.edit'
: draft.params.inReplyToId
? 'post.reply'
: feedName ? `${feedName}.post.create` : 'post.create'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nested ternary makes me sad but I get the necessity of it

@jpezninjo jpezninjo merged commit 23b5c2b into main Nov 8, 2023
3 checks passed
@jpezninjo jpezninjo deleted the fix/post-creation-interactions branch November 8, 2023 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants