This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
fix(UI): hide Translate Post button if a translation API endpoint isn't specified #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaga
changed the title
aaga
force-pushed
the
hide-translate-if-no-api
branch
from
9bab059
to
56a2fcf
Compare
jpezninjo
reviewed
Oct 4, 2023
| @@ -103,7 +103,7 @@ export function useTranslation(status: mastodon.v1.Status | mastodon.v1.StatusEd | |||
| && supportedTranslationCodes.includes(to as any) | |||
| && supportedTranslationCodes.includes(status.language as any) | |||
| && !userSettings.value.disabledTranslationLanguages.includes(status.language) | |||
| const enabled = /*! !useRuntimeConfig().public.translateApi && */ shouldTranslate | |||
There was a problem hiding this comment.
I'm very interested in why this was just a single ! before lol
There was a problem hiding this comment.
@jpezninjo oh lol yeah I was wondering that too; but if you look closer the second ! is there right after the /*. How it got there,, i don't know.
There was a problem hiding this comment.
Ah that makes complete sense. Good eye!
jpezninjo
approved these changes
Oct 4, 2023
anthony-liddle
approved these changes
Oct 5, 2023
aaga
force-pushed
the
hide-translate-if-no-api
branch
from
56a2fcf
to
29a032f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was poking around translation-related things and discovered this old commit from upstream that I think introduced a bug with
shouldTranslatebehavior.Figured I'd open a PR to revert that change and hide the translate button, since we don't know have a roadmap for adding translation yet.