This repository has been archived by the owner on Oct 31, 2019. It is now read-only.
Exclude WONTFIX/DUPLUCATE and other resolutions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
👍 I haven't been able to test it locally yet myself. |
|
This is fine and works, but the original idea behind assigned was to indicate how many tasks has that person undertaken, irrespective of completing them or not. The code is fine, but the meaning of assigned is changing, so would like some opinions on this. |
|
Hmm, true. I guess the proposed new meaning is "How many tasks does the person intend to eventually complete". Not sure if that's better than the current one. I guess it depends on why we want an "assigned" column in the leaderboard in the first place :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes one is assigned to a bug which has been marked WONTFIX or INVALID or DUPLICATE. In such a case, it probably should not count as part of the leaderboard, since it's never going to be fixed.
This PR restricts the count of "assigned" bugs to open bugs which either have no resolution, or are FIXED.