MCL-19983 & WEB-1429 Fixed legacy skin loading & server authentication. #33

craftycodie · 2021-11-02T12:00:09Z

Summary of Changes

MCL-19983 Skin Fix

Per MCL-19983, this pull requests fixes skins in legacy versions of Minecraft by registering a custom HTTP protocol, to essentially override requests to the URL where skins used to be back then.
The protocol uses authlib to fetch skins just like modern versions of Minecraft do.

I believe this is the only way to fix this skin issue, as skins used to be hosted at s3.amazonaws.com, it is unlikely it can be resolved server-side.

WEB-1429 Server Login Fix

As described in WEB-1429, it is currently impossible to join secured (online-mode=true) legacy servers. The game used to authenticate via minecraft.net, but this has since been moved. I have solved this using a custom HTTP handler which intercepts the server login request before it is performed, and uses Authlib to perform this request instead.

I believe this is the only suitable solution for this bug, as legacy minecraft versions are written to use HTTP rather than HTTPS, and include the access token in the URL, so handling this on the server side is insecure, and it should be done on the client side instead.

Additional Information

Since legacy Minecraft does not support the slim skin model, slim skins will be appropriately stretched out for the classic model. The screenshot below is an example of a slim skin.

I have also updated log4j, due to the infamous vulnerability, you can see #34 for more on that.

Deployment

Were this pull request accepted, to deploy the fix would require updating launcher manifest JSON files for legacy versions. The json files would need launchwrapper bumped to the latest version, and would need some additional dependencies for authlib, the same ones modern minecraft has.
The new dependencies are:

org.apache.logging.log4j:log4j-api:2.16.0
org.apache.logging.log4j:log4j-core:2.16.0
org.apache.logging.log4j:log4j-slf4j18-impl:2.16.0
com.mojang:authlib:2.3.31
com.google.code.gson:gson:2.8.0
org.apache.commons:commons-lang3:3.5
com.google.guava:guava:21.0
commons-io:commons-io:2.5
commons-codec:commons-codec:1.10

Testing Guidance

Skins

Launch a legacy version using the new launchwrapper with any custom skin.
Load into any world and after a moment your custom skin should appear.

Server Login

Start a legacy server with an online-mode fix applied (you can find one here, there are many others.)
Join the server.

ExplodingBottle · 2021-11-02T14:18:15Z

This pull request seems well coded !
But I'm pretty sure it won't be included because Mojang no longer checks pull requests...

RealEMK · 2021-11-02T16:06:18Z

I really hope Mojang gets to working on this. I've been asking for a fix for 6-7 years now.

Patbox · 2021-11-02T21:04:12Z

While it would be nice addition, sadly LegacyLauncher is somewhat abandoned (as it's also questionable in case of licence/ownership). I don't think it will be ever merged (but proof me wrong Mojang)

PhoenixVX · 2021-11-02T21:22:30Z

👍

craftycodie · 2021-11-02T22:31:22Z

While it would be nice addition, sadly LegacyLauncher is somewhat abandoned (as it's also questionable in case of licence/ownership). I don't think it will be ever merged (but proof me wrong Mojang)

Worth a shot!

yellowcheeseman · 2021-11-04T11:10:16Z

I hope this gets fixed. Would like to have skins on old minecraft versions.

peterix · 2021-11-04T14:28:27Z

@craftycodie
This looks like it could be reused even without LaunchWrapper.

Would you be OK with me using this in the MultiMC launcher startup jar?

Code is here:
https://github.com/MultiMC/Launcher/tree/develop/libraries/launcher

And licensed under Apache 2.0.

craftycodie · 2021-11-05T10:25:07Z

@peterix it can indeed, I originally wrote this fix for my own launcher for legacy versions, it might be worth you having a look at that as it's protocol contains more fixes such as online-mode.

https://github.com/craftycodie/MineOnline/blob/main/src/main/java/gg/codie/mineonline/protocol/MineOnlineURLStreamHandler.java

Feel free!

src/main/java/net/minecraft/launchwrapper/protocol/SkinURLConnection.java

TorutheRedFox · 2022-04-02T18:34:12Z

this would also require setting minecraftArguments in the JSON to ${auth_player_name} ${auth_session} --gameDir ${game_directory} --assetsDir ${game_assets} --tweakClass net.minecraft.launchwrapper.AlphaVanillaTweaker for certain versions (most notably Alpha and earlier Beta versions)

craftycodie · 2022-04-26T16:49:02Z

this would also require setting minecraftArguments in the JSON to "${auth_player_name} ${auth_session} --gameDir ${game_directory} --assetsDir ${game_assets} --tweakClass net.minecraft.launchwrapper.AlphaVanillaTweaker" for certain versions (most notably Alpha and earlier Beta versions)

I think this is only required for Alpha 1.2.6.

RealEMK · 2022-04-27T03:00:40Z

@craftycodie This looks like it could be reused even without LaunchWrapper.

Would you be OK with me using this in the MultiMC launcher startup jar?

Code is here: https://github.com/MultiMC/Launcher/tree/develop/libraries/launcher

And licensed under Apache 2.0.

Did you end up adding that to MultiMC?
Currently use PolyMC but would love for an easy fix.

Added online-mode fix.

EasternBloxxer · 2023-01-14T11:22:54Z

@Mojang/Members

EasternBloxxer

🍳

MrMasrozYTLIVE · 2023-01-14T13:02:55Z

@Mojang accept it

thegu5

!!!

FoxBlocks

Please let it happen, Mojang.

halotroop2288 · 2023-08-24T15:38:19Z

Top 10 reasons to hate Mojang:
4. The length of time this PR has been open and the amount of reviews it has gotten without a response from Mojang

This is the most basic form of maintenance, and the fix has been sitting, ready to go for years.

Doodle173 · 2023-11-15T16:39:24Z

Any updates on this issue?

powerboat9 · 2023-11-15T17:23:34Z

At this point people should just use a mod like this. Mojang is ultimately self interested and unwilling to cooperate

MrMasrozYTLIVE · 2023-11-30T17:38:52Z

SkinFix was implemented in PrismLauncher 8.0 with pull request PrismLauncher/PrismLauncher#443

FoxBlocks · 2023-12-02T19:45:33Z

SkinFix was implemented in PrismLauncher 8.0 with pull request PrismLauncher/PrismLauncher#443

Because the community does what Ninten-- er, Mojang don't.

niceEli · 2024-07-28T14:23:55Z

Seems like good PR

Dwalley3DT · 2024-08-08T05:34:04Z

Does this fix include /whitelist add username user not found uuid endpoint error or is this only for older versions authentication & skins as stated? I know it is not called out, to be fair I did not check but hoping it does (apologies). Stellar job on these fixes by the way, thank you! It actually took a while to find ANY real info, the majority of results had a series of old issue logs on jira stating it's resolved then closed but I couldn't find an actual fix anywhere near the place. Until, perhaps, by accident, I stumbled in on an umpteenth jira post on which someone made a post that brought me here, thank you for that post too.

maximuslotro

Looks good, Fixes my issues with skins when compiling and running locally!

amyspark-ng

cool

MCL-19983 Fixed legacy skin loading.

3105a19

craftycodie mentioned this pull request Nov 2, 2021

Skins to work on old mc versions #12

Closed

craftycodie commented Nov 24, 2021

View reviewed changes

src/main/java/net/minecraft/launchwrapper/protocol/SkinURLConnection.java Show resolved Hide resolved

A little refactoring.

bd7172e

calmilamsy mentioned this pull request May 30, 2022

Have BetaCraft Support PolyMC/PolyMC#681

Open

1 task

TheKodeToad mentioned this pull request Nov 12, 2022

Add optional fixes for loading skins in legacy versions PrismLauncher/PrismLauncher#443

Merged

craftycodie and others added 6 commits December 21, 2022 17:37

Updated log4j

bcd7ea4

Removed reference to internal HttpURLConnection

b011d88

Corrected skin adjustments (thanks @DelofJ)

afdcc29

Added online-mode fix.

8e4d5ad

Merge pull request #2 from craftycodie/feature/online-mode

76f25d5

Added online-mode fix.

Version Bump

834a4a5

craftycodie changed the title ~~MCL-19983 Fixed legacy skin loading.~~ MCL-19983 & WEB-1429 Fixed legacy skin loading & server authentication. Dec 21, 2022

MisterSheeple approved these changes Dec 21, 2022

View reviewed changes

PhoenixVX approved these changes Dec 22, 2022

View reviewed changes

MrMasrozYTLIVE approved these changes Dec 22, 2022

View reviewed changes

Jadestrouble approved these changes Dec 22, 2022

View reviewed changes

GameHerobrine approved these changes Dec 23, 2022

View reviewed changes

RealTriassic approved these changes Jan 9, 2023

View reviewed changes

EasternBloxxer approved these changes Jan 14, 2023

View reviewed changes

halotroop2288 approved these changes Feb 13, 2023

View reviewed changes

thegu5 approved these changes Feb 13, 2023

View reviewed changes

Owen2k6 approved these changes Mar 16, 2023

View reviewed changes

RhysB approved these changes May 2, 2023

View reviewed changes

mudkipdev approved these changes May 9, 2023

View reviewed changes

Jab125 approved these changes May 18, 2023

View reviewed changes

FoxBlocks approved these changes Jun 26, 2023

View reviewed changes

7n9 approved these changes Aug 23, 2023

View reviewed changes

Moresteck approved these changes Aug 23, 2023

View reviewed changes

sshshark approved these changes Aug 23, 2023

View reviewed changes

arceuss approved these changes Aug 24, 2023

View reviewed changes

thecow275 approved these changes Aug 27, 2023

View reviewed changes

ExplodingBottle approved these changes Sep 7, 2023

View reviewed changes

AlphaMode approved these changes Dec 20, 2023

View reviewed changes

EternalllZM approved these changes Jun 14, 2024

View reviewed changes

niceEli approved these changes Jul 28, 2024

View reviewed changes

maximuslotro approved these changes Aug 26, 2024

View reviewed changes

amyspark-ng approved these changes Aug 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MCL-19983 & WEB-1429 Fixed legacy skin loading & server authentication. #33

MCL-19983 & WEB-1429 Fixed legacy skin loading & server authentication. #33

craftycodie commented Nov 2, 2021 •

edited

Loading

ExplodingBottle commented Nov 2, 2021

RealEMK commented Nov 2, 2021

Patbox commented Nov 2, 2021

PhoenixVX commented Nov 2, 2021

craftycodie commented Nov 2, 2021

yellowcheeseman commented Nov 4, 2021

peterix commented Nov 4, 2021

craftycodie commented Nov 5, 2021

TorutheRedFox commented Apr 2, 2022 •

edited

Loading

craftycodie commented Apr 26, 2022

RealEMK commented Apr 27, 2022

EasternBloxxer commented Jan 14, 2023

EasternBloxxer left a comment

MrMasrozYTLIVE commented Jan 14, 2023

thegu5 left a comment

FoxBlocks left a comment

halotroop2288 commented Aug 24, 2023

Doodle173 commented Nov 15, 2023

powerboat9 commented Nov 15, 2023

MrMasrozYTLIVE commented Nov 30, 2023 •

edited

Loading

FoxBlocks commented Dec 2, 2023

niceEli commented Jul 28, 2024

Dwalley3DT commented Aug 8, 2024

maximuslotro left a comment

amyspark-ng left a comment

MCL-19983 & WEB-1429 Fixed legacy skin loading & server authentication. #33

Are you sure you want to change the base?

MCL-19983 & WEB-1429 Fixed legacy skin loading & server authentication. #33

Conversation

craftycodie commented Nov 2, 2021 • edited Loading

Summary of Changes

MCL-19983 Skin Fix

WEB-1429 Server Login Fix

Additional Information

Deployment

Testing Guidance

Skins

Server Login

ExplodingBottle commented Nov 2, 2021

RealEMK commented Nov 2, 2021

Patbox commented Nov 2, 2021

PhoenixVX commented Nov 2, 2021

craftycodie commented Nov 2, 2021

yellowcheeseman commented Nov 4, 2021

peterix commented Nov 4, 2021

craftycodie commented Nov 5, 2021

TorutheRedFox commented Apr 2, 2022 • edited Loading

craftycodie commented Apr 26, 2022

RealEMK commented Apr 27, 2022

EasternBloxxer commented Jan 14, 2023

EasternBloxxer left a comment

Choose a reason for hiding this comment

MrMasrozYTLIVE commented Jan 14, 2023

thegu5 left a comment

Choose a reason for hiding this comment

FoxBlocks left a comment

Choose a reason for hiding this comment

halotroop2288 commented Aug 24, 2023

Doodle173 commented Nov 15, 2023

powerboat9 commented Nov 15, 2023

MrMasrozYTLIVE commented Nov 30, 2023 • edited Loading

FoxBlocks commented Dec 2, 2023

niceEli commented Jul 28, 2024

Dwalley3DT commented Aug 8, 2024

maximuslotro left a comment

Choose a reason for hiding this comment

amyspark-ng left a comment

Choose a reason for hiding this comment

craftycodie commented Nov 2, 2021 •

edited

Loading

TorutheRedFox commented Apr 2, 2022 •

edited

Loading

MrMasrozYTLIVE commented Nov 30, 2023 •

edited

Loading