Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dispatch codec receiving null decoders more gracefully #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThatGravyBoat
Copy link

The KeyDispatchCodec assumes that a decoder can never be null when received as such it causes an npe when trying to use it. This PR changes it so that the dispatch methods on the Codec class now check if the Codec returned is null and returns an appropriate DataResult error and the decoder call in KeyDispatchCodec gives a generic DataResult error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant