Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appdata and translation related patches #220

Merged
merged 5 commits into from Jan 7, 2024
Merged

Appdata and translation related patches #220

merged 5 commits into from Jan 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2024

appdata: Update appdata

  • Add vcs-browser and translate URLs
  • Add the translation tag
  • Mark the developer name and release descriptions as untranslatable
  • Remove redundant paragraph from the translation document

po: Update Turkish translation

@ghost ghost changed the title Fix appdata Appdata and translation related patches Jan 6, 2024
@MightyCreak
Copy link
Owner

I just fixed an issue with Python 3.12 (which might be the reason why the CI/CD fails on your MR). Could you rebase your branch?

@MightyCreak
Copy link
Owner

I merged #222 and rebased your branch on main. Apparently there is still an issue with the meson build. I think it's coming from the CI/CD configuration (maybe the appstreamcli doesn't exist or is too old). I'll check that.

@MightyCreak
Copy link
Owner

I found the issue!

I cherry-picked your changes and fixed the CI/CD here: #223

Sabri Ünal added 2 commits January 6, 2024 21:41
- Add vcs-browser and translate URLs
- Add the translation tag
- Mark the developer name and release descriptions as untranslatable
- Use appstreamcli to validate appdata
- Remove redundant paragraph from the translation document
@MightyCreak
Copy link
Owner

I merged #223 and I rebased your branch on main. I think it should fix the CI/CD on your branch as well.

@MightyCreak
Copy link
Owner

Well... it still fails...

I don't understand why... I tried the command line in an ubuntu:22.04 container and it worked. I think I'll have to find a way to see what's written in the CI/CD log file.

But it's getting late now, I'll tackle that tomorrow ;)

@MightyCreak
Copy link
Owner

Ok, I got the artifact and here's the error:

W: io.github.mightycreak.Diffuse:50: url-invalid-type vcs-browser
   Invalid `type` property for this `url` tag. URLs of this type are not known in the AppStream
   specification.

@MightyCreak
Copy link
Owner

Well.. apparently I couldn't sleep until I found the source of the issue 😅

The issue was that ubuntu-latest is Ubuntu 22.04, which has appstream 0.15, which is too old to handle URL type vcs-browser. So I changed the docker image to ubuntu-23.04 (until ubuntu-latest will point to 23.04 too).

It's fixed now!
Merging your PR now!

Thanks!

@MightyCreak MightyCreak merged commit 90ec27e into MightyCreak:main Jan 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant