Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Update-M365TeamsApp.md #12317

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

srimantabagchi
Copy link
Contributor

Update documentation for Update-M365TeamsApp

Copy link

Learn Build status updates of commit 1545aeb:

💡 Validation status: suggestions

File Status Preview URL Details
teams/teams-ps/teams/Update-M365TeamsApp.md 💡Suggestion View (teams-ps) Details

teams/teams-ps/teams/Update-M365TeamsApp.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'satishtimiri/sribagchi' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 48bab2e:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365TeamsApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@jacktremper jacktremper added the Sign off The pull request is ready to be reviewed and merged by PubOps label Oct 28, 2024
@padmagit77 padmagit77 self-assigned this Oct 28, 2024
@padmagit77 padmagit77 added the In review PubOps is reviewing the pull request label Oct 28, 2024
Copy link

Learn Build status updates of commit 4b1e61e:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365TeamsApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit dc71b54:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365TeamsApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@padmagit77
Copy link
Contributor

Hi @srimantabagchi

Following is a blocking issue that need to be resolved before we can merge:

The identifiers used on lines 52 to 59 don't seem to follow the approved pattern for GUIDs.


Reference

[Criteria used for pull request reviews](https://review.learn.microsoft.com/en-us/office-authoring-guide/pr-criteria?branch=main#content-and-formatting)

Blocking


  • Use approved identifiers on lines 52 to 59.

After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again.

If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel.

Thanks,
Padma

@padmagit77 padmagit77 added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates In review PubOps is reviewing the pull request and removed In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Oct 28, 2024
@padmagit77
Copy link
Contributor

@srimantabagchi

I rechecked and realized that the IDs are ok as per https://learn.microsoft.com/en-us/troubleshoot/entra/entra-id/governance/verify-first-party-apps-sign-in#application-ids-of-commonly-used-microsoft-applications. I am going ahead and merging the PR.

Thanks
Padma

@padmagit77 padmagit77 merged commit 9f258d5 into MicrosoftDocs:main Oct 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review PubOps is reviewing the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants