Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to live - Feb 28, 2024 #971

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Merge main to live - Feb 28, 2024 #971

merged 3 commits into from
Feb 28, 2024

Conversation

jehchow
Copy link
Contributor

@jehchow jehchow commented Feb 28, 2024

Contributor guide pull request

Thanks for contributing to the Microsoft Learn contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.

Quality control

  • 1. Successful build with no warnings: Review the build status to make sure all checks are green (Succeeded).

  • 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

  • All PRs to this repository are manually reviewed and merged.
  • Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?

  • If you have an open PR, tag the PR reviewers in comment with your question: @carlyrevier, @jehchow
  • Open an issue in this repo and tag the PR reviewers.

Copy link

Learn Build status updates of commit ce853d4:

💡 Validation status: suggestions

File Status Preview URL Details
Contribute/docfx.json 💡Suggestion Details

Contribute/docfx.json

  • Line 1, Column 1: [Suggestion: uhf-header-id-missing - See documentation] uhfHeaderId should not be null; specify the uhfHeaderId in global metadata of docfx.json file.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 8d5849c:

💡 Validation status: suggestions

File Status Preview URL Details
Contribute/docfx.json 💡Suggestion Details

Contribute/docfx.json

  • Line 1, Column 1: [Suggestion: uhf-header-id-missing - See documentation] uhfHeaderId should not be null; specify the uhfHeaderId in global metadata of docfx.json file.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@jehchow
Copy link
Contributor Author

jehchow commented Feb 28, 2024

#sign-off

@carlyrevier carlyrevier merged commit 872907b into live Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants