Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contribute page index.md to current GitHub procedure #796

Closed
wants to merge 1 commit into from
Closed

Update Contribute page index.md to current GitHub procedure #796

wants to merge 1 commit into from

Conversation

orcmid
Copy link
Contributor

@orcmid orcmid commented Jul 28, 2023

In fixing a simple speed bump between Quick edit steps 2-3, I discovered that the overall procedure has changed, as presented to the Edge browser.

I have not replaced the images. If review confirms the changes to the text, I am happy to provide new captures of the dialogs.

Contributor guide pull request

Thanks for contributing to the Microsoft Learn documentation contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.

Quality control

  • 1. Successful build with no warnings: Review the build status to make sure all checks are green (Succeeded).

  • 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

  • All PRs to this repository are manually reviewed and merged.
  • Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?

  • See our guidance on Contributing to the contributor guide for help with adding or updating content in this contributor guide.
  • Write to the PR reviewer in the PR comments: @carlyrevier, @jehchow

In fixing a simple speed bump between Quick edit steps 2-3, I discovered that the overall procedure has changed, as presented to the Edge browser.

I have **not** replaced the images.  If review confirms the changes to the text, I am happy to provide new captures of the dialogs.
@orcmid
Copy link
Contributor Author

orcmid commented Jul 28, 2023

  1. I apologize for not cleaning the Pull-request template before submitting.
  2. There may be a further glitch with regard to the current GitHub procedure. It appears that the pull request is created at step (5) but it remains staged at the automatic fork (orcmid/Contribute in this case) and is not yet submitted to the origin (Microsoft/Contribute). I ended up completing the pull request at GitHub. (I wasn't certain what trying it from the Github Windows client would accomplish.)

I will confirm (2) when I do another run-through and capture new dialog images. I don't want to delay review of this much though.

PS: The link in the Need Help? of the pull-request template, Contributing to the contributor guide is completely bogus.

@carlyrevier
Copy link
Collaborator

carlyrevier commented Aug 14, 2023

Closing because this is superseded by/addressed in #813. Thank you for these investigations and feedback. We'd appreciate feedback on the new instructions as you use them. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants