Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET MAUI Community Toolkit - RatingView #472

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

GeorgeLeithead
Copy link
Contributor

This pull request introduces the documentation for the RatingView control, to accompany the code under .NET MAUI Community Toolkit PR for RatingView.

Only merge, after the code PR has been merged.

Copy link

Learn Build status updates of commit cc9d8bc:

💡 Validation status: suggestions

File Status Preview URL Details
docs/maui/views/RatingView.md 💡Suggestion View Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View

docs/maui/views/RatingView.md

  • Line 194, Column 47: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/shapes.path' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@GeorgeLeithead GeorgeLeithead marked this pull request as draft September 23, 2024 16:14
@GeorgeLeithead GeorgeLeithead marked this pull request as ready for review September 23, 2024 16:18
Copy link

Learn Build status updates of commit 81c73f4:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@GeorgeLeithead
Copy link
Contributor Author

@bijington Just a nudge to remind you that this is here and ready for review.

Copy link
Collaborator

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorgeLeithead thank you for this. Most comments I think are easily addressed.

Also I think we need to update the top.yml file for any new file added to the docs

docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Show resolved Hide resolved
docs/maui/views/RatingView.md Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
Copy link

Learn Build status updates of commit 2c05a73:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit b70120d:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit a36121f:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit f831f67:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 5b7a137:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 878beb7:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit dfab374:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView_CustomShape.png ✅Succeeded View
docs/maui/images/views/RatingView_Shape.png ✅Succeeded View
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Removed base class properties and added appropriate link
Copy link

Learn Build status updates of commit 1545332:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView_CustomShape.png ✅Succeeded View
docs/maui/images/views/RatingView_RatingFill.png ✅Succeeded View
docs/maui/images/views/RatingView_Shape.png ✅Succeeded View
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@GeorgeLeithead
Copy link
Contributor Author

@GeorgeLeithead thank you for this. Most comments I think are easily addressed.

Also I think we need to update the top.yml file for any new file added to the docs

Updated the TOC correctly.

Copy link

Learn Build status updates of commit 8ac4fa3:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView_CustomShape.png ✅Succeeded View
docs/maui/images/views/RatingView_RatingFill.png ✅Succeeded View
docs/maui/images/views/RatingView_Shape.png ✅Succeeded View
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't major items and I'm not against shipping with them tbh

docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
docs/maui/views/RatingView.md Outdated Show resolved Hide resolved
Copy link

Learn Build status updates of commit 98fda1a:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView_CustomShape.png ✅Succeeded View
docs/maui/images/views/RatingView_RatingFill.png ✅Succeeded View
docs/maui/images/views/RatingView_Shape.png ✅Succeeded View
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e6c1f25:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView_CustomShape.png ✅Succeeded View
docs/maui/images/views/RatingView_RatingFill.png ✅Succeeded View
docs/maui/images/views/RatingView_Shape.png ✅Succeeded View
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2949b07:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView_CustomShape.png ✅Succeeded View
docs/maui/images/views/RatingView_RatingFill.png ✅Succeeded View
docs/maui/images/views/RatingView_Shape.png ✅Succeeded View
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 6e524b7:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/images/views/RatingView_CustomShape.png ✅Succeeded View
docs/maui/images/views/RatingView_RatingFill.png ✅Succeeded View
docs/maui/images/views/RatingView_Shape.png ✅Succeeded View
docs/maui/images/views/RatingView.png ✅Succeeded View
docs/maui/TOC.yml ✅Succeeded View
docs/maui/views/index.md ✅Succeeded View
docs/maui/views/RatingView.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants