-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET MAUI Community Toolkit - RatingView #472
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit cc9d8bc: 💡 Validation status: suggestions
docs/maui/views/RatingView.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 81c73f4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@bijington Just a nudge to remind you that this is here and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeorgeLeithead thank you for this. Most comments I think are easily addressed.
Also I think we need to update the top.yml file for any new file added to the docs
Co-authored-by: Shaun Lawrence <[email protected]>
Co-authored-by: Shaun Lawrence <[email protected]>
Co-authored-by: Shaun Lawrence <[email protected]>
Learn Build status updates of commit 2c05a73: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Shaun Lawrence <[email protected]>
Learn Build status updates of commit b70120d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit a36121f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Shaun Lawrence <[email protected]>
Learn Build status updates of commit f831f67: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 5b7a137: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 878beb7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit dfab374: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Removed base class properties and added appropriate link
Learn Build status updates of commit 1545332: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Updated the TOC correctly. |
Learn Build status updates of commit 8ac4fa3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These aren't major items and I'm not against shipping with them tbh
Learn Build status updates of commit 98fda1a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit e6c1f25: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 2949b07: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 6e524b7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
This pull request introduces the documentation for the
RatingView
control, to accompany the code under .NET MAUI Community Toolkit PR for RatingView.Only merge, after the code PR has been merged.