Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet_requestpermissions update local provider accounts #1081

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

abretonc7s
Copy link
Collaborator

Explanation

Using wallet_requestPermissions is used to trigger an "account selection" request on the wallet to let the user choose a different accounts. Before this PR, triggering this rpc call on mobile would change the permissions but not reflect them on the sdk for future calls.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner October 17, 2024 13:24
@abretonc7s abretonc7s enabled auto-merge (squash) October 17, 2024 13:59
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.41%. Comparing base (7f89423) to head (9610730).

Files with missing lines Patch % Lines
...kages/sdk/src/provider/initializeMobileProvider.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   77.69%   77.41%   -0.28%     
==========================================
  Files         179      179              
  Lines        4209     4224      +15     
  Branches     1031     1038       +7     
==========================================
  Hits         3270     3270              
- Misses        939      954      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 17, 2024

Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit cfba775 into main Oct 17, 2024
8 checks passed
@abretonc7s abretonc7s deleted the fix/walletrequestpermissions branch October 17, 2024 14:29
@abretonc7s abretonc7s mentioned this pull request Oct 17, 2024
christopherferreira9 pushed a commit that referenced this pull request Oct 18, 2024
* fix: rpc protocol resetting after refresh

* feat: multiple sdk improvements

* feat: wip

* fix: unit tests

* fix: unit tests

* feat: restore deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants