Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColumnChooser: align with Pager elements #5654

Open
wants to merge 1 commit into
base: rel-1.6
Choose a base branch
from
Open

ColumnChooser: align with Pager elements #5654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Source/Extensions/Blazorise.DataGrid/_DataGridPagination.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@typeparam TItem
@inherits BaseComponent
<Row class="@ClassNames" style="@StyleNames" @attributes="@Attributes">
<Column ColumnSize="ColumnSize.IsAuto" Flex="Blazorise.Flex.Row.AlignItems.Center">
<Column ColumnSize="ColumnSize.IsAuto" Flex="Blazorise.Flex.Row">
stsrki marked this conversation as resolved.
Show resolved Hide resolved
@if ( GetButtonRowPosition() == PagerElementPosition.Start || GetButtonRowPosition() == PagerElementPosition.Default )
{
@buttonRowFragment
Expand All @@ -20,7 +20,7 @@
}
</Column>

<Column ColumnSize="ColumnSize.IsAuto" Flex="Blazorise.Flex.Row.AlignItems.Center" Margin="Blazorise.Margin.IsAuto.OnX">
<Column ColumnSize="ColumnSize.IsAuto" Flex="Blazorise.Flex.Row" Margin="Blazorise.Margin.IsAuto.OnX">
@if ( GetButtonRowPosition() == PagerElementPosition.Center )
{
@buttonRowFragment
Expand Down Expand Up @@ -117,7 +117,7 @@
{
@if ( ShowColumnChooser )
{
<Field Display="Blazorise.Display.InlineBlock" Margin="Blazorise.Margin.IsAuto.OnY.Is2.FromStart">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only remove Y margin, and leave the rest Margin="Blazorise.Margin.Is2.FromStart"

<Field Display="Blazorise.Display.InlineBlock">
<Dropdown @bind-Visible="@dropdownColumnChooserVisible">
<DropdownToggle @onclick:stopPropagation>
<Icon Name="@IconName.Table" Margin="Blazorise.Margin.Is1.FromStart" Clicked="() => {}" /> Columns
Expand Down
Loading