MC-9766 - Reorganise the repo to support multiple Angular projects #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved into an Angular project folder to rework the workspace. Committed files are only renamed, commit history is maintained.
Tested that existing eslint and license-check commands work with new project structure
* Run through `ng test` Angular builder now * Update config files and Jenkins build file
* Make sure distribution build still works * Update jest reporters to output report files to new locations * Update Jenkins build to reference correct file locations * Update npm scripts * Clean up redundant files
pjmonks
force-pushed
the
feature/mc-9766
branch
from
369193c
to
69fd55b
Compare
|
|
|
Marking this as a draft PR for now. Due to the way some other planned work has panned out, this re-organisation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code for the
mdm-uiapplication has been reorganised to support multiple Angular projects within the same workspace. This will prepare the repo to contain further UI applications/projects.Changes made:
srcfolder have been moved toprojects/mdm-ui/src. Files have been moved usinggit mvcommand to only rename files and maintain original commit history.angular.jsonfile which is now responsible for all Angular projects inside this workspace.npmscripts still work. The default workspace project is stillmdm-ui, so existing commands likenpm startwill still default to servingmdm-ui. Other scripts liketest,eslint,distetc have been updated to work with the new structure.Jenkinsfilehas been updated to ensure that any file references now point to new locations.@olliefreeman - I have asked for your review also specifically to check the
Jenkinsfile. I've seen that a Jenkins branch build passes still, and becausenpm run distis used and still outputs the build output todist/mdm-ui-<version>,tgzthen there should not be any major changes with deployments.