Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add en and fr as (the only) languages that can be selected via lang attribute on <mapml-viewer> or ancestors #999

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add en and fr as (the only) languages that can be selected via lang attribute on <mapml-viewer> or ancestors #999

wants to merge 8 commits into from

Conversation

prushforth
Copy link
Member

@prushforth prushforth commented Oct 17, 2024 •
edited
Loading

  • ancestors are light DOM only, for now. tbd if want to search across shadow boundaries.
  • Initial commit (no tests, most popup stuff not localized yet)
  • other languages omitted (for now) since translated strings are loaded at page load via the bundle, which is too costly

Closes #994

prushforth and others added 8 commits October 17, 2024 16:02
@yushan-mu yushan-mu mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider prototype support for the global lang attribute on <mapml-viewer>
2 participants
@prushforth @yushan-mu