Finish issue 3804 and pass all the tests of number_line #3962
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,114 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| from manim import * | |||
Check notice
Code scanning / CodeQL
'import *' may pollute namespace Note
| class AnimatableNumberLine(NumberLine): | ||
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
| self.x_range_tracker = ValueTracker(self.x_range) |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
There was a problem hiding this comment.
Thanks for trying to tackle this issue, it's something we've wanted to get to for a while now :)
However, I'm not sure that creating a new class is the right way to go, because it could cause confusion when to use the normal classes vs the Animatable* versions. I believe it should be possible to use the original classes to add this behavior.
What do you think?
Overview: What does this pull request change?
Change number_line.py and add animatable_coordinate_systems.py
Motivation and Explanation: Why and how do your changes improve the library?
To fix issue #3804
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist