feat: add bookmarks for objects #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjousse
force-pushed
the
feat/add-object-bookmarks
branch
from
cdd3dbf
to
6333d63
Compare
vjousse
force-pushed
the
feat/add-object-bookmarks
branch
from
6333d63
to
e7ee09b
Compare
n1k0
reviewed
Oct 7, 2024
vjousse
force-pushed
the
feat/add-object-bookmarks
branch
from
8d3e90b
to
3a292fe
Compare
n1k0
force-pushed
the
feat/add-object-bookmarks
branch
from
3a292fe
to
f5405e0
Compare
n1k0
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
The first version of the object interface doesn't manage bookmarks.
🍰 Solution
Implement the bookmark mechanism already available for the food and textile sections.
🚨 Points to watch/comments
The
toStringon theQueryobject to find a default name for the bookmark may be questionnable.🏝️ How to test
Go on the review app https://ecobalyse-pr781.osc-fr1.scalingo.io/#/object/simulator and try to save/load simulations for the object interface using the bottom right tab.