Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Bases Two Teams Let's PvP #358

Closed
wants to merge 18 commits into from

Conversation

leolegPremiumPlus
Copy link

Finisehd ;) A BIG thanks to ScaleKRaker :D

@HobbitPower
Copy link
Contributor

HobbitPower commented Aug 12, 2024

@leolegPremiumPlus There will be more detailed feedback in the future, but you might want to think of a different name. The name is quite long and not meaningful and could refer to any 2-team map.
You should also adapt the folder name as soon as you have found a new name and shorten it considerably. You can customize it yourself via Github (You can find a short explanation here, you have to use your own fork and branch respectively.) or it would be easier if you create a new PR. Perhaps @ScaleRaker can also help you with this.

@leolegPremiumPlus
Copy link
Author

@leolegPremiumPlus There will be more detailed feedback in the future, but you might want to think of a different name. The name is quite long and not meaningful and could refer to any 2-team map. You should also adapt the folder name as soon as you have found a new name and shorten it considerably. You can customize it yourself via Github (You can find a short explanation here, you have to use your own fork and branch respectively.) or it would be easier if you create a new PR. Perhaps @ScaleRaker can also help you with this.

Do you think "Kingdoms war : red vs blue" or "Game of kingdoms" is good ?

@leolegPremiumPlus
Copy link
Author

i think Game of Kingdoms is crazy xD

@Themostrandom
Copy link
Contributor

Several comments:
The name is too long, like the underlined Hobbit
I think the addition of more standards would add rp
I would reduce the number of plants and flowers, it's beautiful but to put blocks it's disturbing
Some areas are empty (under the house)
There's a hole in the attic on both sides (inside).
For my part, I think there's a lack of items in the chests to be able to pvp as the name of your map indicates.
There's a hole in the ground on the river side
There's a hole in the roof of the towers (no problem, either fill it in or make it bigger).
The underside of the map is not made of indestructible block.

I like your map overall despite these problems, it reminds me in general configuration my map arena pvp which is in review :)

@Themostrandom
Copy link
Contributor

Because you are french :
Plusieurs remarques :
Le nom est trop long comme la souligné Hobbit
Je penses que l'ajout de plus d’étendard ajouterais du rp
Je réduirais le nombre de plante et fleurs, c'est beau mais pour poser des blocks cela est dérangeant
Certaines zones sont vides (sous la maison)
Il y a un trou dans le grenier des deux coté (a l'interieur)
Pour ma part je pense qu'il manque d'item dans les coffres pour pouvoir pvp comme le nom de votre map l'indique.
Il y a un trou dans le sol coté rivière
Il y a un trou dans le toit des tour (pas genant, soit le combler soit l'agrandir)
Le dessous de la map n'est pas en block indestructible

J'aime bien votre map dans l'ensemble malgré ces problèmes, elle me rapelle dans la configuration général ma map arena pvp qui est en review :)

@HobbitPower
Copy link
Contributor

i think Game of Kingdoms is crazy xD

It's better than the current one, for sure

@ScaleRaker
Copy link
Contributor

I agree that the name should be changed. I'm not really sure what you mean by "standards" per say. One of the things that I wanted to do with this map was to make it harder for players to pillar, hence adding all the vegetation. leoleg can decide what to do with this one. The empty areas under the base I commented on myself but I did not I didn't do anything about because I didn't think of really anything to put there. Something should definitely go there though. The hole in the attic pertains to the same situation. I'm not really sure what you mean by "lack of items" to pvp with. AFAIK, nothing has changed with the chests. The holes as well as the bottom of the map being destructable are definitely my fault and are an oversight which should be able to be easily fixed. Unfortunately, it's unlikely that I will be able to work on this map for a while, but when I can, I'll try to fix the problems.

@ScaleRaker
Copy link
Contributor

As always, this is leoleg's map, not mine, so I'm just putting some ideas out there, not finalizing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants