Disable the use of LLD by default #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use LLD by default if it is available for reasons mentioned in #2986. The use of LLD can now be enabled by using -DMRTRIX_USE_LLD=ON. Additionally, we use CMake's check_cxx_compiler_flag to see if the compiler supports LLD regardless of the platform (instead of simply relying on the presence of ld.lld).
|
clang-tidy review says "All clean, LGTM! 👍" |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use LLD by default if it is available for reasons mentioned in #2986. The use of LLD can now be enabled by using
-DMRTRIX_USE_LLD=ON. This option only exists as a convenience and will be removed once our target CMake version matches 3.19 or higher (as we will be able to leverage CMake presets to achieve the same thing).Additionally, we use CMake's
check_cxx_compiler_flagto see if the compiler supports LLD regardless of the platform (instead of simply relying on the presence ofld.lld).