run.command(): Change to shebang handling #2970
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
If the command being run is an MRtrix3 executable (as established by the construction of that list at build time), and it is written in Python, then use the same Python interpreter as that currently executing. In any other circumstance, honour the shebang as specified in the command being invoked.
Lestropie
force-pushed
the
mrtrix3_run_shebang_alternative
branch
from
786a27b
to
87a0e37
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision to #2966 as described in comment.
If the command being run is an MRtrix3 executable (as established by the construction of that list at build time), and it is written in Python, then use the same Python interpreter as that currently executing. In any other circumstance, honour the shebang as specified in the command being invoked.
This is I think:
Leaving as draft because I'll try to do some cross-checking on my Windows system first (and shouldn't be merged before #2859 revisions).