Fix drag & drop on Windows for mrview #2886
Conversation
There was a problem hiding this comment.
Confirmed resolves issue on my Windows machine. But only for specifically dragging & dropping main images. There are also toolbars where a user may attempt to drag & drop a file, which this changeset currently won't resolve. Would suggest functionalising the decoding of filesystem paths from a drop event, and make use of it across those multiple contexts:
- Overlay tool
- Connectome tool
- Fixel plot
- Tractography tool
- ROI editor
Note that the ODF display tool is intentionally omitted from this list: this is because the type of ODF cannot be reliably inferred from just the input image data alone, and so the user is forced to nominate the type of ODF by clocking on the corresponding button.
|
To address your comment, I've now introduced a new |
|
clang-tidy review says "All clean, LGTM! 👍" |
daljit46
force-pushed
the
fix_drag_drop_mrview_windows
branch
from
5f05d13
to
4ae723f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
daljit46
force-pushed
the
fix_drag_drop_mrview_windows
branch
2 times, most recently
from
3b70261
to
7135b36
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
There was a problem hiding this comment.
Fixed non-compilation by bringing up to date with dev.
Tested drag & drop on the listed toolbars.
Do maintain this should be back-propagated to master. But given the code formatting changes would cause conflicts across the board, could maybe merge this, manually re-implement on master, and then on dev accept only the dev-based change?
|
clang-tidy review says "All clean, LGTM! 👍" |
Sounds good to me. |
A new QtHelpers namespace has been introduced which contains a helper function to convert a QUrl to a std::string, ensuring that local URLs are parsed correctly on all platforms.
daljit46
force-pushed
the
fix_drag_drop_mrview_windows
branch
from
0004afe
to
1f2656d
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Should address #1373