-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drag & drop on Windows for mrview #2886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed resolves issue on my Windows machine. But only for specifically dragging & dropping main images. There are also toolbars where a user may attempt to drag & drop a file, which this changeset currently won't resolve. Would suggest functionalising the decoding of filesystem paths from a drop event, and make use of it across those multiple contexts:
- Overlay tool
- Connectome tool
- Fixel plot
- Tractography tool
- ROI editor
Note that the ODF display tool is intentionally omitted from this list: this is because the type of ODF cannot be reliably inferred from just the input image data alone, and so the user is forced to nominate the type of ODF by clocking on the corresponding button.
To address your comment, I've now introduced a new |
clang-tidy review says "All clean, LGTM! 👍" |
5f05d13
to
4ae723f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
3b70261
to
7135b36
Compare
clang-tidy review says "All clean, LGTM! 👍" |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed non-compilation by bringing up to date with dev
.
Tested drag & drop on the listed toolbars.
Do maintain this should be back-propagated to master
. But given the code formatting changes would cause conflicts across the board, could maybe merge this, manually re-implement on master
, and then on dev
accept only the dev
-based change?
clang-tidy review says "All clean, LGTM! 👍" |
Sounds good to me. |
A new QtHelpers namespace has been introduced which contains a helper function to convert a QUrl to a std::string, ensuring that local URLs are parsed correctly on all platforms.
0004afe
to
1f2656d
Compare
clang-tidy review says "All clean, LGTM! 👍" |
Should address #1373