Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove git submodule for testing data #2848

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Remove git submodule for testing data #2848

merged 4 commits into from
Sep 12, 2024

Commits on Sep 10, 2024

  1. Use ExternalProject to download test data at build time 

    We now download testing data at build time instead of cloning the data as a git submodule.
The user can also provide local git repos for the data by specifying the MRTRIX_BINARIES_DATA_DIR and MRTRIX_SCRIPTS_DATA_DIR environment variables during the configuration stage.
This prevents from polluting the source directory and it's more in line with CMake's philosophy.
    @daljit46
    daljit46 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    153d03c View commit details
    Browse the repository at this point in the history

  2. Remove testing data submodules

    @daljit46
    daljit46 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5fba417 View commit details
    Browse the repository at this point in the history

  3. Update commit hashes for testing data repos

    @daljit46
    daljit46 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3a7d2f7 View commit details
    Browse the repository at this point in the history

  4. Log location of local testing data directories

    @daljit46
    daljit46 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    91ac695 View commit details
    Browse the repository at this point in the history