Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 6.0 Permission Code #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZKjellberg
Copy link

Early revision of my permission check code. Starting off with Navigator app and trying to track down all calls for Location and doing a permission check prior to making the call.

This will prevent the crash mentioned in issue #192, but does not address requesting the permissions. I think it would be smart to export the onCreate() location calls into the startLocationUpdates().

This is a bit challenging as I could implement the Locationpermission call inside startLocationUpdates. I could lump in the storage call here as well which should provide a good workflow.

I'll revisit this later.

@ZKjellberg
Copy link
Author

Does Tuto actually need Location? When testing, I can't seem to trigger any code which uses it. This class should be easy since it doesn't make permission calls frequently. I can simply do the permission check on first launch, explaining the need for storage for tiles.

I assume Tuto stands for Tutorial? I couldn't figure it out until I saw the comment stating it implements the tutorials

@ZKjellberg ZKjellberg changed the title Early Permission Code Android 6.0 Permission Code Jan 7, 2016
@ZKjellberg
Copy link
Author

I've implemented code for osmbonuspacktuto's requirement for storage access. As I couldn't find any evidence of using Location, I did not add the prompt. I added the permission check at the end of the onCreate() because the application seemed unable to show the Toast message if placed at beginning. This may relate to the threading instructions.

I'll revisit OSMNavigator later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant