-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI option to list available modules in mod_dir #15
base: master
Are you sure you want to change the base?
Conversation
…ule dir. Works in conjunction with -M option.
@@ -28,6 +28,8 @@ options: | |||
-i INTERFACE, --interface=INTERFACE | |||
interface to listen on | |||
-m, --module_info print information about module(s) and exit | |||
-m, --all_module_list | |||
print list of modules available and exit. Works with -M option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to mention -M here.
This doesn't work when using -B though, and it should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If -B is specified, wouldn't mod_dir incorporate that on line 507 of ChopLib.py? Since the added code walks mod_dir, I thought this solution would handle -B. (Definitely correct me if I'm wrong - today is my first time looking at this code.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought it would have worked too but it doesn't.
wxs@psh chopshop % ./chopshop -B ~/chopshop_modules -a
It just hangs. I can provide more input if you can not reproduce this. You can probably get away with making a dummy chopshop module and putting it in ~/chopshop_modules/modules to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I attempt the same line (after making that directory), I get "No modules found in directory" as a result, as expected. Could it be an environment issue? I'm testing on OS X 10.8.4.
…dir, since modules are not loaded from subdirs.
This is still not working when using -B. I'm not able to debug it right now either. I'll be in touch with you to help figure this out. |
Absolutely - give me a shout when you have time. I've tested it on my machine and it works fine for me with the -B option, so I'd like to work with you to figure it out! |
Attempt to resolve #11 by adding a new option flag.