Create plotting functions for viscosity function and running viscosity #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Plots result of class `ViscosityHelfand` * Write tests for plotting function
* Write tests for running viscosity plotting function * Improve variable name in `plot_viscosity_function()`
xhgchen
force-pushed
the
plot-viscosity
branch
from
bd27457
to
43f7424
Compare
xhgchen
changed the title
hmacdope
reviewed
Aug 20, 2023
| @@ -211,3 +217,86 @@ def _conclude(self): | |||
| ) | |||
| # average over # particles and update results array | |||
| self.results.timeseries = self.results.visc_by_particle.mean(axis=1) | |||
| self._run_called = True | |||
|
|
|||
| def plot_viscosity_function(self, start=0, stop=0, step=1): | |||
There was a problem hiding this comment.
What is meant by function in the name here?
There was a problem hiding this comment.
I was referring to eq. 5 of E M Kirova and G E Norman 2015 J. Phys.: Conf. Ser. 653 012106
It is actually the product of viscosity and time as a function of time. You take the slope of it to obtain viscosity. Here is a direct link to the article: https://iopscience.iop.org/article/10.1088/1742-6596/653/1/012106
There was a problem hiding this comment.
Okay you should add this info to the docs and also to the docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Changes made in this Pull Request:
ViscosityHelfandViscosityHelfand