Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pandas<2.1 and add cron trigger to CI #92

Merged
merged 9 commits into from
Sep 19, 2023
Merged

pin pandas<2.1 and add cron trigger to CI #92

merged 9 commits into from
Sep 19, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Sep 14, 2023

temporarily addressing #93 and see MDAnalysis/MDAKits#67

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #92 (b53e281) into main (055cbd9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@IAlibay IAlibay mentioned this pull request Sep 14, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Sep 14, 2023

Ok can confirm it's pandas 2.1 :/

@orbeckst orbeckst mentioned this pull request Sep 18, 2023
2 tasks
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements.txt is missing

@orbeckst orbeckst changed the title Add cron trigger to CI pin pandas<2.1 and add cron trigger to CI Sep 18, 2023
@orbeckst
Copy link
Member

For completeness I also pinned in requirements.txt

@orbeckst
Copy link
Member

The cryptic RTD error

 python -mvirtualenv $READTHEDOCS_VIRTUALENV_PATH
usage: virtualenv [--version] [--with-traceback] [-v | -q] [--read-only-app-data] [--app-data APP_DATA] [--reset-app-data] [--upgrade-embed-wheels] [--discovery {builtin}] [-p py] [--try-first-with py_exe]
                  [--creator {builtin,cpython3-posix,venv}] [--seeder {app-data,pip}] [--no-seed] [--activators comma_sep_list] [--clear] [--no-vcs-ignore] [--system-site-packages] [--symlinks | --copies] [--no-download | --download]
                  [--extra-search-dir d [d ...]] [--pip version] [--setuptools version] [--wheel version] [--no-pip] [--no-setuptools] [--no-wheel] [--no-periodic-update] [--symlink-app-data] [--prompt prompt] [-h]
                  dest
virtualenv: error: the following arguments are required: dest
SystemExit: 2 

is due to how you have specify conda/mamba in the rtd config file. I just ran into this the other day in Becksteinlab/GromacsWrapper#258 and Becksteinlab/GromacsWrapper@756b8a8

Let me have a quick look.

@orbeckst
Copy link
Member

Let's see if just using mambaforge works while letting RTD figure out the rest.

@orbeckst
Copy link
Member

docs/requirements.yaml does not contain pandas... let's see if it works

@orbeckst
Copy link
Member

This built the docs https://readthedocs.org/projects/solvation-analysis/builds/21958960/ although I am now slightly puzzled because the package wasn't installed. Presumably, sphinx imported the source directly. Check that the docs look right. Then possibly try adding

python:
  install:
    - method: pip
      path: .

if something needs to be done.

@orbeckst
Copy link
Member

There are problems on RTD, see https://readthedocs.org/projects/solvation-analysis/builds/21958960/ (last command)

Running Sphinx v7.2.6
WARNING: Invalid configuration value found: 'language = None'. Update your configuration to a valid language code. Falling back to 'en' (English).
making output directory... done
[autosummary] generating autosummary for: api.rst, api/coordination.rst, api/networking.rst, api/pairing.rst, api/plotting.rst, api/residence.rst, api/solute.rst, api/speciation.rst, getting_started.ipynb, index.rst, tutorials.rst, tutorials/basics_tutorial.ipynb, tutorials/clustering_and_residence_tutorial.ipynb, tutorials/multi_atom_solutes.ipynb, tutorials/plotting_tutorial.ipynb, tutorials/rdf_fitting_demo.ipynb, tutorials/visualization_tutorial.ipynb
/home/docs/checkouts/readthedocs.org/user_builds/solvation-analysis/conda/92/lib/python3.11/site-packages/MDAnalysis/topology/TPRParser.py:161: DeprecationWarning: 'xdrlib' is deprecated and slated for removal in Python 3.13
  import xdrlib
WARNING: Failed to import solvation_analysis.plotting.
Possible hints:
* AttributeError: module 'solvation_analysis' has no attribute 'plotting'
* ModuleNotFoundError: No module named 'plotly'

@hmacdope
Copy link
Member

@orbeckst is the RTD stuff resolved or persisting? If it's all good I can merge.

@orbeckst
Copy link
Member

RTD builds so the immediate problem is solved. The issue with plotly can probably be fixed in another PR — I don’t want to add it to the RTD dependencies because I haven’t seen it as a dependency elsewhere. That will require someone with more insight than me.

@orbeckst
Copy link
Member

RTD is happy https://solvation-analysis--92.org.readthedocs.build/en/92/tutorials/plotting_tutorial.html — no complaints about missing packages.

@orbeckst
Copy link
Member

Thanks for adding plotly, @IAlibay —- I should have looked more carefully at the other requirement files because it was listed elsewhere, I just overlooked it.

@IAlibay IAlibay merged commit 514472c into main Sep 19, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants