Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package modernization #103

Merged
merged 17 commits into from
May 7, 2024
Merged

Package modernization #103

merged 17 commits into from
May 7, 2024

Conversation

orionarcher
Copy link
Collaborator

@orionarcher orionarcher commented May 7, 2024

Description

This adds typing, linting, and the ability to import Solute directly from solvation_analysis.

Fixes issues #100

TODO

  • add hook
  • lint all files
  • get tests passing
  • update documentation imports
  • add documentation on how to use default kwarg

Status

  • Ready to go

@pep8speaks
Copy link

pep8speaks commented May 7, 2024

Hello @orionarcher! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 182:10: E203 whitespace before ':'

Line 122:57: E203 whitespace before ':'
Line 194:23: E203 whitespace before ':'
Line 211:36: E203 whitespace before ':'
Line 348:57: E203 whitespace before ':'

Line 906:54: E203 whitespace before ':'

Comment last updated at 2024-05-07 19:17:59 UTC

@orionarcher orionarcher changed the title Typing Package modernization May 7, 2024
@orionarcher orionarcher mentioned this pull request May 7, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@orionarcher orionarcher merged commit c7022aa into main May 7, 2024
15 checks passed
@richardjgowers richardjgowers mentioned this pull request Jul 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants