Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread safety to fix race conditions around usage of static IDict… #142

Merged
merged 4 commits into from
Nov 19, 2023

Conversation

udlose
Copy link
Contributor

@udlose udlose commented Jan 23, 2023

…ionary instances. Note these should be converted to use ConcurrentDictionary to avoid the performance overhead of using static lock objects.

@udlose
Copy link
Contributor Author

udlose commented Jan 23, 2023

Apologies for the formatting changes. My VS has some custom settings that are locked by my employer.

@udlose
Copy link
Contributor Author

udlose commented Aug 29, 2023

I've updated the code to remove the extraneous formatting. Please review again.

Dave Black and others added 4 commits November 19, 2023 17:28
…ionary instances. Note these should be converted to use ConcurrentDictionary<T> to avoid the performance overhead of using static lock objects.
@devlead devlead added the bug label Nov 19, 2023
@devlead devlead added this to the 0.19.0 milestone Nov 19, 2023
@devlead devlead removed the bug label Nov 19, 2023
@devlead devlead removed this from the 0.19.0 milestone Nov 19, 2023
@devlead devlead merged commit ac3889c into LitJSON:develop Nov 19, 2023
9 of 10 checks passed
@devlead
Copy link
Member

devlead commented Nov 19, 2023

@udlose your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants