Add Loopback Socket #326
Open
Add Loopback Socket #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2024 18:54
JustinCappos
reviewed
Oct 4, 2024
| @@ -445,7 +447,32 @@ impl Cage { | |||
| let res = match sockhandle.domain { | |||
| AF_UNIX => self.bind_inner_socket_unix(sockhandle, &mut newsockaddr), | |||
| AF_INET | AF_INET6 => { | |||
| self.bind_inner_socket_inet(sockhandle, &mut newsockaddr, prereserved) | |||
| let loopback_addr = u32::from_ne_bytes([127, 0, 0, 7]); | |||
| self.bind_inner_socket_inet(sockhandle, &mut newsockaddr, prereserved) | ||
| let loopback_addr = u32::from_ne_bytes([127, 0, 0, 7]); | ||
| match newsockaddr.addr() { | ||
| interface::GenIpaddr::V4(addr) => { |
| @@ -890,6 +917,7 @@ impl Cage { | |||
| //by other threads accessing other fields | |||
| let sock_tmp = sockfdobj.handle.clone(); | |||
| let mut sockhandle = sock_tmp.write(); | |||
|
|
|||
| let mut remoteaddr_final = remoteaddr.clone(); | ||
|
|
||
| if remoteaddr.get_family() == AF_INET as u16 { | ||
| let loopback_addr = u32::from_ne_bytes([127, 0, 0, 7]); |
There was a problem hiding this comment.
Shouldn't define this twice. Use a constant or similar in once place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds loopback socket (127.0.0.7) for rustposix
Fixes # (issue)
Type of change
How Has This Been Tested?
ipc_tests.rs/ut_lind_ipc_loopback_socketChecklist: