Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another pitfall to docs that can happen when using rank_zero_only decorator in lightning #2719

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 4, 2024

What does this PR do?

Fixes #2684

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2719.org.readthedocs.build/en/2719/

@mergify mergify bot added the ready label Sep 4, 2024
@mergify mergify bot requested a review from a team September 4, 2024 19:32
@mergify mergify bot requested a review from a team September 6, 2024 09:26
@Borda Borda merged commit 858096c into master Sep 6, 2024
49 of 56 checks passed
@Borda Borda deleted the docs/rank_zero_pitfall branch September 6, 2024 09:26
Borda pushed a commit that referenced this pull request Sep 11, 2024
… decorator in lightning (#2719)

* fix docs
* missing import
* Apply suggestions from code review

---------

Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 858096c)
Borda pushed a commit that referenced this pull request Sep 13, 2024
… decorator in lightning (#2719)

* fix docs
* missing import
* Apply suggestions from code review

---------

Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 858096c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrechetInceptionDistance hangs when used with multiple devices in PytorchLightning
2 participants