Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3/n) Data Refactor - Add JSON Module #971

Merged
merged 6 commits into from
Feb 29, 2024
Merged

(3/n) Data Refactor - Add JSON Module #971

merged 6 commits into from
Feb 29, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 29, 2024

I'm adding a JSON data module before landing #968 and #950 because there is extensive documentation of how to "finetune on your own dataset" and I'd like to change the docs only once.

It replaces the CSV module because the csv format is not really practical for storing instruction text data.

You would use it like this:

python finetune/full.py --data JSON --data.json_path path/to/my/data.json

(after the above PRs are merged)

@awaelchli awaelchli changed the title (3/n) Data Refactor - Add JSON Module #950 (3/n) Data Refactor - Add JSON Module Feb 29, 2024
@awaelchli awaelchli marked this pull request as ready for review February 29, 2024 12:00
@carmocca carmocca merged commit fcc74bc into main Feb 29, 2024
8 checks passed
@carmocca carmocca deleted the refactor/data-json branch February 29, 2024 12:24
@carmocca carmocca added this to the Configurability milestone Mar 1, 2024
rasbt pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants