Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and exports #147

Merged
merged 3 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ export default tseslint.config(
...tseslint.configs.strict,
...tseslint.configs.stylistic,
{
ignores: ['dist/*', 'test/browser/main.js'],
ignores: ['gen-nodejs/*', 'dist/**/*', 'dist/*', 'test/browser/main.js'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged with the other one that was below this

},
{
rules: {
'no-loss-of-precision': 'off',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so we don't get double warnings. See line 20.

// TODO: Fix/ignore in tests and remove
'@typescript-eslint/no-loss-of-precision': 'warn',
// TODO: Fix and remove
Expand Down Expand Up @@ -44,6 +45,15 @@ export default tseslint.config(
},
},
{
ignores: ['gen-nodejs/*', 'dist/**/*'],
files: ['**/*.test.ts', 'test/**/*', 'examples/**/*'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore some things in tests.

rules: {
'@typescript-eslint/no-require-imports': 'off',
'@typescript-eslint/no-unused-expressions': 'off',
'no-loss-of-precision': 'off',
'@typescript-eslint/no-loss-of-precision': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-unused-vars': 'off',
},
}
);
2 changes: 1 addition & 1 deletion gen-nodejs/parquet_types.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Autogenerated by Thrift Compiler (0.18.1)
// Autogenerated by Thrift Compiler (0.21.0)
//
// DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
//
Expand Down
4 changes: 3 additions & 1 deletion lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { PrimitiveType, OriginalType, ParquetType, FieldDefinition, ParquetField
import { Options } from './codec/types';
import type { Document as BsonDocument } from 'bson';
// BSON uses top level awaits, so use require for now
// eslint-disable-next-line @typescript-eslint/no-require-imports
const bsonSerialize = require('bson').serialize;
// eslint-disable-next-line @typescript-eslint/no-require-imports
const bsonDeserialize = require('bson').deserialize;

interface ParquetTypeDataObject {
Expand Down Expand Up @@ -552,7 +554,7 @@ function toPrimitive_TIMESTAMP_MICROS(value: Date | string | number | bigint) {
}

return v;
} catch (e) {
} catch (_e) {
throw 'TIMESTAMP_MICROS value is out of bounds: ' + value;
}
}
Expand Down
Loading
Loading