-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update journal-related typings for v10 #2119
Open
rsek
wants to merge
68
commits into
League-of-Foundry-Developers:main
Choose a base branch
from
rsek:v10-journal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2022
rsek
changed the title
update JournalEntry + add JournalEntryPage typings for v10.277
update JournalEntry + add JournalEntryPage typings for v10
Oct 11, 2022
LukeAbby
requested changes
Oct 14, 2022
kmoschcau
added
version update
This tracks an update to a Foundry VTT version
foundry v10
This belongs to Foundry VTT version 10
apps
This issue is related to an Application or ApplicationV2 class
labels
Oct 16, 2022
kmoschcau
requested changes
Oct 16, 2022
Co-authored-by: Kai Moschcau <[email protected]>
Co-authored-by: Kai Moschcau <[email protected]>
Co-authored-by: Kai Moschcau <[email protected]>
Co-authored-by: Kai Moschcau <[email protected]>
Co-authored-by: Kai Moschcau <[email protected]>
Is there anything I can do to assist with getting this unstuck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apps
This issue is related to an Application or ApplicationV2 class
foundry v10
This belongs to Foundry VTT version 10
version update
This tracks an update to a Foundry VTT version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates the typings for
JournalEntry
and adds typings forJournalEntryPage
, along with their corresponding sheet applications and schemas.