Refactor locations for common types #6708
checks.yml
on: push
type check code base
24s
lint code base
33s
test code base
28s
Annotations
24 errors and 3 warnings
type check code base:
src/foundry/client/apps/forms/effect-config.d.mts#L55
Interface 'ActiveEffectConfigData<Options>' incorrectly extends interface 'DocumentSheetData<Options, ActiveEffect>'.
|
type check code base:
src/foundry/client/core/packages.d.mts#L149
Type of property 'packs' circularly references itself in mapped type '{ [Key in keyof Schema]: Schema[Key] extends DataField<any, any, any, infer PersistType extends unknown> ? Schema[Key] extends SchemaField<infer SubSchema extends DataSchema, any, any, any, any> ? RemoveIndexSignatures<...> : PersistType : never; }'.
|
type check code base:
src/foundry/client/core/packages.d.mts#L149
Type of property 'packs' circularly references itself in mapped type '{ [Key in keyof Schema]: Schema[Key] extends DataField<any, any, infer InitType, any> ? Schema[Key] extends EmbeddedDataField<infer Model extends Any, any, any, any, any> ? Model : Schema[Key] extends SchemaField<...> ? RemoveIndexSignatures<...> : InitType : never; }'.
|
type check code base:
src/foundry/client/core/packages.d.mts#L149
Type of property 'packs' circularly references itself in mapped type '{ [Key in keyof Schema]?: Schema[Key] extends DataField<any, infer AssignType, any, any> ? Schema[Key] extends SchemaField<infer SubSchema extends DataSchema, any, any, any, any> ? EmptyObject extends RemoveIndexSignatures<...> ? RemoveIndexSignatures<...> | ... 1 more ... | undefined : RemoveIndexSignatures<...> : ...'.
|
type check code base:
src/foundry/common/documents/actor-delta.d.mts#L20
Type of property 'cards' circularly references itself in mapped type '{ [Key in keyof Schema<string>]?: Schema<string>[Key] extends DataField<any, infer AssignType, any, any> ? Schema<string>[Key] extends SchemaField<...> ? EmptyObject extends RemoveIndexSignatures<...> ? RemoveIndexSignatures<...> | ... 1 more ... | undefined : RemoveIndexSignatures<...> : AssignType : never; }'.
|
type check code base:
src/foundry/common/documents/actor-delta.d.mts#L20
Type of property 'combatants' circularly references itself in mapped type '{ [Key in keyof Schema]?: Schema[Key] extends DataField<any, infer AssignType, any, any> ? Schema[Key] extends SchemaField<infer SubSchema extends DataSchema, any, any, any, any> ? EmptyObject extends RemoveIndexSignatures<...> ? RemoveIndexSignatures<...> | ... 1 more ... | undefined : RemoveIndexSignatures<...> : ...'.
|
type check code base:
src/foundry/common/documents/actor-delta.d.mts#L20
Type of property 'delta' circularly references itself in mapped type '{ [x: string]: any; _id?: AssignmentType<DefaultOptions>; actorId?: AssignmentType<BaseActor, { idOnly: true; }>; delta?: RemoveIndexSignatures<...> | ... 1 more ... | undefined; ... 24 more ...; flags?: DerivedAssignmentType<...>; }'.
|
type check code base:
src/foundry/common/documents/actor-delta.d.mts#L20
Type of property 'drawings' circularly references itself in mapped type '{ [Key in keyof Schema]?: Schema[Key] extends DataField<any, infer AssignType, any, any> ? Schema[Key] extends SchemaField<infer SubSchema extends DataSchema, any, any, any, any> ? EmptyObject extends RemoveIndexSignatures<...> ? RemoveIndexSignatures<...> | ... 1 more ... | undefined : RemoveIndexSignatures<...> : ...'.
|
type check code base:
src/foundry/common/documents/actor-delta.d.mts#L20
Type of property 'effects' circularly references itself in mapped type 'Readonly<RemoveIndexSignatures<{ [x: string]: any; _id: InitializedType<DefaultOptions>; name: string; type: string; img: InitializedType<{ categories: "IMAGE"[]; initial: (data: unknown) => string; }>; ... 6 more ...; _stats: RemoveIndexSignatures<...>; }>>'.
|
type check code base:
src/foundry/common/documents/actor-delta.d.mts#L20
Type of property 'effects' circularly references itself in mapped type 'RemoveIndexSignatures<{ [x: string]: any; _id: InitializedType<DefaultOptions>; name: string; type: string; img: InitializedType<{ categories: "IMAGE"[]; initial: (data: unknown) => string; }>; ... 6 more ...; _stats: RemoveIndexSignatures<...>; }>'.
|
tests/foundry/client/config.test-d.ts:
tests/foundry/client/config.test-d.ts#L3
TypeCheckError: Types of construct signatures are incompatible.
Type 'new (formula string, data? {} | undefined, options? InexactPartial<EvaluationOptions> | undefined) => D20Roll' is not assignable to type 'new <D extends object = {}>(formula string, data? D | undefined, options? InexactPartial<EvaluationOptions> | undefined) => Roll<D>'.
Type 'D20Roll' is not assignable to type 'Roll<D>'.
Type '{}' is not assignable to type 'D'.
'{}' is assignable to the constraint of type 'D', but 'D' could be instantiated with a different subtype of constraint 'object'.
❯ tests/foundry/client/config.test-d.ts:3:1
|
tests/foundry/client/game.test-d.ts:
tests/foundry/client/game.test-d.ts#L34
TypeCheckError: Type 'Module' does not satisfy the constraint '{ [x string] never; }'.
Index signature for type 'string' is missing in type 'Module'.
❯ tests/foundry/client/game.test-d.ts:34:66
|
tests/foundry/prosemirror/prosemirror.test-d.ts:
tests/foundry/prosemirror/prosemirror.test-d.ts#L8
TypeCheckError: Property 'defaultSchema' does not exist on type 'typeof import("/home/runner/work/foundry-vtt-types/foundry-vtt-types/src/foundry/prosemirror/prosemirror")'.
❯ tests/foundry/prosemirror/prosemirror.test-d.ts:8:26
|
tests/foundry/prosemirror/prosemirror.test-d.ts:
tests/foundry/prosemirror/prosemirror.test-d.ts#L8
TypeCheckError: Type 'Schema<any, any>' does not satisfy the constraint 'never'.
❯ tests/foundry/prosemirror/prosemirror.test-d.ts:8:55
|
tests/foundry/client/pixi/board.test-d.ts:
tests/foundry/client/pixi/board.test-d.ts#L5
TypeCheckError: Type 'ConstructorOf<CanvasLayer>' does not satisfy the constraint 'typeof CanvasLayer'.
❯ tests/foundry/client/pixi/board.test-d.ts:5:57
|
tests/foundry/client/pixi/board.test-d.ts:
tests/foundry/client/pixi/board.test-d.ts#L5
TypeCheckError: Type 'ConstructorOf<CanvasLayer>' does not satisfy the constraint 'typeof CanvasLayer'.
Type 'ConstructorOf<CanvasLayer>' is missing the following properties from type 'typeof CanvasLayer' layerOptions, instance, defaultSortableChildren, mixin, and 2 more.
❯ tests/foundry/client/pixi/board.test-d.ts:5:57
|
tests/foundry/client/pixi/board.test-d.ts:
tests/foundry/client/pixi/board.test-d.ts#L5
TypeCheckError: Argument of type 'Layers' is not assignable to parameter of type 'Record<string, LayerDefinition<ConstructorOf<CanvasLayer>>>'.
'string' index signatures are incompatible.
Type 'LayerDefinition<typeof CanvasLayer>' is not assignable to type 'LayerDefinition<ConstructorOf<CanvasLayer>>'.
Type 'typeof CanvasLayer' is not assignable to type 'ConstructorOf<CanvasLayer>'.
Cannot assign an abstract constructor type to a non-abstract constructor type.
❯ tests/foundry/client/pixi/board.test-d.ts:5:87
|
tests/foundry/common/abstract/data.mjs.test-d.ts:
tests/foundry/common/abstract/data.mjs.test-d.ts#L18
TypeCheckError: Type 'string | undefined' does not satisfy the constraint 'StrictEqualUsingTSInternalIdenticalToOperator<{ [Key in keyof Schema] Schema[Key] extends DataField<any, any, infer InitType, any> ? Schema[Key] extends EmbeddedDataField<infer Model extends Any, any, any, any, any> ? Model Schema[Key] extends SchemaField<...> ? RemoveIndexSignatures<...> InitType never; }["g...'.
Type 'undefined' is not assignable to type 'StrictEqualUsingTSInternalIdenticalToOperator<{ [Key in keyof Schema] Schema[Key] extends DataField<any, any, infer InitType, any> ? Schema[Key] extends EmbeddedDataField<infer Model extends Any, any, any, any, any> ? Model Schema[Key] extends SchemaField<...> ? RemoveIndexSignatures<...> InitType never; }["g...'.
❯ tests/foundry/common/abstract/data.mjs.test-d.ts:18:54
|
tests/foundry/common/abstract/document.mjs.test-d.ts:
tests/foundry/common/abstract/document.mjs.test-d.ts#L20
TypeCheckError: Property 'effects' does not exist on type 'RemoveIndexSignatures<{ [x string] unknown; }>'.
❯ tests/foundry/common/abstract/document.mjs.test-d.ts:20:37
|
tests/foundry/common/abstract/document.mjs.test-d.ts:
tests/foundry/common/abstract/document.mjs.test-d.ts#L20
TypeCheckError: Type 'RemoveIndexSignatures<{ key string; value string; mode InitializedType<{ integer true; initial 2; label "EFFECT.ChangeMode"; }>; priority InitializedType<DefaultOptions>; }>[]' does not satisfy the constraint 'never'.
❯ tests/foundry/common/abstract/document.mjs.test-d.ts:20:71
|
lint code base:
src/foundry/client/pixi/perception/vision-mode.d.mts#L2
'DataField' is defined but never used. Allowed unused vars must match /^_/u
|
lint code base:
src/foundry/common/data/fields.d.mts#L1192
Definition for rule '@typescript-eslint/no-empty-object-type' was not found
|
lint code base:
tests/foundry/common/documents/combatant.test-d.ts#L7
Replace `Promise<Document.Stored<Combatant>[]>` with `⏎··Promise<Document.Stored<Combatant>[]>⏎`
|
lint code base
Process completed with exit code 1.
|
type check code base
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
test code base
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
lint code base
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|