dont escape when developer error header is present #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uuu that's a very nice solution. I like it, yes! I see no problem, run with it! |
tabacitu
approved these changes
Oct 7, 2024
pxpm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
fixes: #5142
BEFORE - What was wrong? What was happening before this PR?
All errors have the message escaped. In some scenarios we would like to display some html, like a link to docs or similar.
AFTER - What is happening after this PR?
We introduce a way to have "internal" exceptions, errors that occur when developer missed some configuration.
HOW
How did you achieve that, in technical terms?
Introduced a header
developer-error-exceptionthat when present in the exception we don't escape the message, since those errors are internally triggered by backpack, and we control the contents.Is it a breaking change?
I don't think so, no.