Fix save actions when all actions are removed #5672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
fixes: Laravel-Backpack/community-forum#134
BEFORE - What was wrong? What was happening before this PR?
When removing all save actions from the form, Backpack would throw an error.
AFTER - What is happening after this PR?
Backpack can handle empty save actions without crashing.
HOW
How did you achieve that, in technical terms?
Added a check for the emptiness of save actions, and adjusted the view to display the remaining buttons even if save actions are empty.
Is it a breaking change?
I don't think so, no.
How can we test the before & after?
In a create/update operation, do
CRUD::removeAllSaveActions()