allow configurable page headings using tokens #5566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
The main idea behind this came up from #4902
We discussed it internally and aknowledge that the PR as is was not mergeable, and not everyone agreed with the change so it was postponed.
I was doing now a cleanup and stumbled upon it. I was one of the people that liked the "idea" of the PR. So I came up with this solution.
AFTER - What is happening after this PR?
This gives developers the flexibility to configure the page headers beyond just changing a word at a time.
Is this a good idea ? At first it looks 🤷
HOW
How did you achieve that, in technical terms?
Created two new language strings to represent the
page_heading
andpage_subheading
in full. By default accepted the needed parameters, but this can be extended in the future to pass additional parameters.At the moment the available parameters are:
:singular - $crud->entity_name
:plural - $crud->entity_name_plural
:action - trans('crud.add/edit/preview')
,Is it a breaking change?
Maybe not ?