Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add missing attribute on checkbox fields #5454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Feb 26, 2024

Checkbox and Checkbox fields don't use the BS class form-check-input.
Adding the class for Tabler was a non-issue because adding the form-check-input does not break anything and we are able to target the checkboxes without targeting "specific fields" (like the checkbox in a checklist or whatever).

But it breaks for CoreUI's, because the themes provide the attribute styled, but we never used it, and now we would need to release a new CRUD and lock the themes (coreui v2 and v4) to v6.6.x. that I think at this time (very close to a new major), we better do it there I think.

@pxpm pxpm added the v7 label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant