Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate setFromDb() method #5419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate setFromDb() method #5419

wants to merge 1 commit into from

Conversation

promatik
Copy link
Contributor

@promatik promatik commented Jan 7, 2024

@pxpm
Copy link
Contributor

pxpm commented Jan 10, 2024

I agree we do this, but at the same time we remove setFromDB from our stubs too.

Otherwise I don't think it makes sense to deprecate a function that we still use.

The stubs are now publishable too, so if you want to add something back that we removed you can just publish the stubs and do your changes accordingly.

Cheers

@pxpm pxpm assigned promatik and unassigned pxpm Jan 10, 2024
@pxpm pxpm added the v7 label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Testing, Review or Docs
Development

Successfully merging this pull request may close these issues.

3 participants