Added Passer! #131
Merged
Added Passer! #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
reediculous456
requested changes
Mar 18, 2024
| @Override | ||
| public void execute() { | ||
| if (storage.noteExitingStorage()) { | ||
| scoring.feedForAmp(); |
There was a problem hiding this comment.
Why not just use feed for passer all the time?
| public static final int leftStoragePort = 11; | ||
| public static final int rightStoragePort = 8; | ||
| public static final int storagePort = 11; | ||
| // public static final int rightStoragePort = 8; |
There was a problem hiding this comment.
Please remove, not comment
|
|
||
| private Passer() { | ||
| passerMotor.restoreFactoryDefaults(); | ||
| passerMotor.setIdleMode(IdleMode.kBrake); |
There was a problem hiding this comment.
Probably should be coast like shooter
There was a problem hiding this comment.
isn't shooter brake? or is that a different motor than the roller motor?
There was a problem hiding this comment.
Maybe I’m wrong but I thought it was in coast. If not this is fine
reediculous456
requested changes
Mar 18, 2024
|
|
||
| @Override | ||
| public void execute() { | ||
| scoring.feedForAmp(); |
There was a problem hiding this comment.
Calling both feed for amp and feed for passer seems redundant here
|
@Griffin9881 Please review the changes I made. We will need to tune the following to make this efficient:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue Number
Closes #130
Comments