-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made auton delay #124
made auton delay #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you see the code that I pushed? I think it will be a lot easier to work with from a DS standpoint and be more flexible
where did you push that code? |
I feel like a dropdown would be fine since you wouldn't really have a situation where you needed to be more accurate than that. Although when we tested the code did not work Im not sure why not but it looks similar to yours just the WaitCommand is in a different spot |
Interesting, I would expect that to work |
me too |
Does my branch work? I have a theory |
both branches work now because i guess it had to be in the auton class, I would prefer to use my code because I think it would be easier than using a text box and also it was made by a student |
Ok. One thing you could do to reduce the overhead here is remove the enum and just assign the seconds straight to the options in the chooser. The only reason we don’t do that for autons is because we need to construct the auton in auto init not on robot init |
Okay I can work on that tomorrow |
@@ -21,6 +21,7 @@ public enum AutonChoices { | |||
|
|||
// Choosers | |||
SendableChooser<AutonChoices> autoChooser; | |||
SendableChooser<String> delayChooser; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SendableChooser<String> delayChooser; | |
SendableChooser<double> delayChooser; |
If you do this you don’t need the switch statement. You can just return the get value from the chooser
Pull Request
Issue Number
Closes #74
Comments